Closed apoorvagnihotri closed 5 years ago
Change the spelling of dimention to dimension. Also, make sure comments and docstrings have as minimal grammatical errors as possible.
Regarding B-Spline, when there are multiple optional arguments, can you mention the argument type as (int, int) or something? kx, ky, as I see it, do not seem to have this. Also add comments mentioning what each variable means. What does "tck" mean for an example? I'll merge once you make the changes
Is there any reason why function definitions are written your way? The def f(a, B, C) with indentation. I’d avoid that as long as there aren’t too many arguments (<6). No issue tho. We can change later
We should use Black formatter for the code: https://github.com/python/black
Ran black on the following files and directories only:
usage.py
interpolation/trend
interpolation/spline
interpolation/random
interpolation/base
@sdeepaknarayanan I haven't run black on your code files as it will cause problems in merging later.
fit
andpredict
so possibly we can reuse docstring across all the interpolation methods.