sustainability-suite / sustainability-odoo

Odoo module for Sustainability features
GNU Affero General Public License v3.0
14 stars 4 forks source link

Tests are broken #193

Open OdyX opened 3 days ago

OdyX commented 3 days ago

Bug Report

Description

We run the modules' test by default on our CI, and it turns out they're broken on sustainability-odoo:

2024-10-22 08:14:13,737 506 ERROR donkey odoo.tests.suite: ERROR: setUpClass (odoo.addons.sustainability.tests.test_conversion.TestCarbonUom)
Traceback (most recent call last):
  File "/opt/donkey/addons/sustainability/tests/common.py", line 15, in setUpClass
    cls.env.company.write(
  File "/opt/bitnami/odoo/lib/odoo-17.0.post20241005-py3.12.egg/odoo/addons/account/models/company.py", line 400, in write
    return super(ResCompany, self).write(values)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/bitnami/odoo/lib/odoo-17.0.post20241005-py3.12.egg/odoo/addons/product/models/res_company.py", line 65, in write
    ).write(vals)
      ^^^^^^^^^^^
  File "/opt/bitnami/odoo/lib/odoo-17.0.post20241005-py3.12.egg/odoo/addons/web/models/models.py", line 1132, in write
    res = super().write(values)
          ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/bitnami/odoo/lib/odoo-17.0.post20241005-py3.12.egg/odoo/addons/base/models/res_company.py", line 310, in write
    res = super(Company, self).write(values)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/bitnami/odoo/lib/odoo-17.0.post20241005-py3.12.egg/odoo/addons/mail/models/mail_thread.py", line 317, in write
    result = super(MailThread, self).write(values)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/donkey/addons/sustainability/models/carbon_mixin.py", line 370, in write
    res = super().write(vals)
          ^^^^^^^^^^^^^^^^^^^
  File "/opt/bitnami/odoo/lib/odoo-17.0.post20241005-py3.12.egg/odoo/models.py", line 4358, in write
    raise ValueError("Invalid field %r on model %r" % (fname, self._name))
ValueError: Invalid field 'carbon_in_value' on model 'res.company'

Additional Information

It looks like carbon_in_value was removed / renamed in ae500b3814bf1c279e3271f4159672d722612b64 , but the tests never updated.

ben3474 commented 2 days ago

Hi @OdyX thanks for reporting. We will take a look at it.