Closed marvin-steinke closed 7 months ago
@marvin-steinke thanks! can you sign DCO
Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
In your local branch, run: git rebase HEAD~2 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin main
Can we try to have a link to prometheus install steps? Honestly I am not sure if we should cover prometheus steps in our document.... which means for any update on prometheus we should have an update ...
I'm afraid I don't know how to install the Kepler helm package for a non-helm prometheus installation regarding the release label that has to be set. Because of this I included specific instructions for a full helm install. The only way installation instructions for the kube-prometheus-stack are going to change is if the repository stops to exists in which case we would have to link another helm chart anyways, right?
Can we try to have a link to prometheus install steps? Honestly I am not sure if we should cover prometheus steps in our document.... which means for any update on prometheus we should have an update ...
I'm afraid I don't know how to install the Kepler helm package for a non-helm prometheus installation regarding the release label that has to be set. Because of this I included specific instructions for a full helm install. The only way installation instructions for the kube-prometheus-stack are going to change is if the repository stops to exists in which case we would have to link another helm chart anyways, right?
ok, please go ahead to complete this PR and notify me after it's ready for review :-)
serviceMonitor
for the Kepler charts: The valueserviceMonitor.enabled
needs to be set totrue
and the valueserviceMonitor.labels.release
needs to be set to the release name of the kube-prometheus-stack installtion.