search

sustainable-computing-io / kepler-doc

Kepler uses eBPF to probe energy related system stats and exports as Prometheus metrics
https://sustainable-computing.io/
Apache License 2.0
13 stars 37 forks source link

Nit Fix for kepler 1341 #150

Closed SamYuan1990 closed 3 months ago

SamYuan1990 commented 3 months ago

fix https://github.com/sustainable-computing-io/kepler/issues/1341

juangascon commented 3 months ago

@SamYuan1990 Thanks for doing the pull request on my behalf. I had some personal issues to manage and could not propose the pull request. Though, I see in the commit that we are only changing the 'code' block but not the line number 28 explaining the code. We should also modify it from To deploy on a local kind cluster, you need to use the CI_DEPLOY and PROMETHEUS_DEPLOY flags. to To deploy on a local kind cluster, you need to use the PROMETHEUS_DEPLOY flag. I could propose a pull request but I do not know if it is going to mess up if I create it before this commit is merged.

SamYuan1990 commented 3 months ago

@SamYuan1990 Thanks for doing the pull request on my behalf. I had some personal issues to manage and could not propose the pull request. Though, I see in the commit that we are only changing the 'code' block but not the line number 28 explaining the code. We should also modify it from To deploy on a local kind cluster, you need to use the CI_DEPLOY and PROMETHEUS_DEPLOY flags. to To deploy on a local kind cluster, you need to use the PROMETHEUS_DEPLOY flag. I could propose a pull request but I do not know if it is going to mess up if I create it before this commit is merged.

good catch, updated, please help review.

jichenjc commented 3 months ago

don't know whether we need squash the commits the change is good to me