search

sustainable-computing-io / kepler-doc

Kepler uses eBPF to probe energy related system stats and exports as Prometheus metrics
https://sustainable-computing.io/
Apache License 2.0
13 stars 39 forks source link

Add review changes #73

Closed husky-parul closed 1 year ago

husky-parul commented 1 year ago

Add review changes from PR https://github.com/sustainable-computing-io/kepler-doc/pull/72

husky-parul commented 1 year ago

@stleerh Please TAL

husky-parul commented 1 year ago

We need to figure out how to set up the SA so that we do not need to configure the token so often. Maybe someone expert in setting up OpenShift User Workload monitoring can help with this.

I request that we close this PR and take up the suggestions in another PR because that would need making changes in kepler-operator and is beyond the scope of this PR.

sthaha commented 1 year ago

@husky-parul

We need to figure out how to set up the SA so that we do not need to configure the token so often. Maybe someone expert in setting up OpenShift User Workload monitoring can help with this.

https://cloud.redhat.com/blog/thanos-querier-versus-thanos-querier explains how to setup GrafanaDatasource : See section Setup Grafana Operator

sthaha commented 1 year ago

@husky-parul

I request that we close this PR and take up the suggestions in another PR because that would need making changes in kepler-operator and is beyond the scope of this PR.

💯 to not bikeshedding! Please feel free to only address the comment that are within the scope of this PR and ignore the rest so that we can merge this one.

We can revisit topics outside the scope of this PR in subsequent PRs

rootfs commented 1 year ago

@husky-parul can you follow up with @sthaha and address the reviews in another PR? Thanks!