search

sustainable-computing-io / kepler-operator

Kepler Operator
Apache License 2.0
25 stars 26 forks source link

feat: operator deploys servicemonitor #223

Closed sthaha closed 1 year ago

sthaha commented 1 year ago

This PR adds a feature to the operator to deploy a servicemonitor to monitor the kepler exporter service. It also modifies grafana deployment script to remove its deployment of servicemonitor and rely on the ServiceMonitor deployed by the operator.

sthaha commented 1 year ago

@vprashar2929 FYI

BGrasnick commented 1 year ago

This is such a welcome addition so we don't have to set it up and deploy it separately! I was just wondering if there are any uses cases / scenarios where users might not want or need the ServiceMonitor? If so would it be possible to make it configurable but deploy by default? Just some thoughts :)

sthaha commented 1 year ago

@BGrasnick thanks, yes, I did think of it but felt to cater for the most frequent usecase. We can definitely (based on feedback) config specific to configuring and deploying servicemonitor.