search

sustainable-computing-io / kepler-operator

Kepler Operator
Apache License 2.0
25 stars 26 forks source link

Running local-cluster using `make cluster-up` fails when kind is not pre-installed #259

Closed husky-parul closed 1 year ago

husky-parul commented 1 year ago

I encountered this issue when reviewing the PR

When I run make cluster-up I see the following

 🔆🔆🔆  Ensuring all tools are installed  🔆🔆🔆 
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 🔔 installing all tools ...
 🔔 installing controller-gen with version: v0.12.1
go: downloading sigs.k8s.io/controller-tools v0.12.1
go: downloading github.com/spf13/cobra v1.7.0
go: downloading k8s.io/api v0.27.1
go: downloading k8s.io/apimachinery v0.27.1

But the command failed on a machine with no pre-installed kind

Starting kind with cluster name kind

 ❯ kind create cluster --name=kind -v6 --config=/home/parsingh/go/src/github.com/test-pr/kepler-operator/tmp/local-dev-cluster/tmp/kind/kind.yml

/home/parsingh/go/src/github.com/test-pr/kepler-operator/tmp/local-dev-cluster/lib/utils.sh: line 50: kind: command not found
make: *** [Makefile:120: cluster-up] Error 127

Shouldn't the make command ensures that we have kind pre-installed as well? I will open a corresponding issue in the kepler-operator

vprashar2929 commented 1 year ago

For this, I believe we added a check in local-dev-cluster to validate whether kind is available or not but looks like the check didn't work as expected as I think it found kubectl to be available. Will work on fixing this

vprashar2929 commented 1 year ago

@husky-parul Please feel free to give make cluster-up a go again.

sthaha commented 1 year ago

closing this as resolved by https://github.com/sustainable-computing-io/local-dev-cluster/pull/50