search

sustainable-computing-io / kepler-operator

Kepler Operator
Apache License 2.0
25 stars 26 forks source link

Feat: export correct namespace #307

Closed BGrasnick closed 6 months ago

BGrasnick commented 9 months ago

This PR makes the ServiceMonitor relabel namespace to have the same value as container_namespace instead of "openshift-kepler-operator" applied after scraping so that it is more straight-forward to use the metrics.

Also adds label "openshift.io/cluster-monitoring": "true" so that the metrics get scraped by openshift-monitoring instead of user workload monitoring which makes usage more straight-forward. I am not sure if this is wanted for kepler-operator but in our use case it would be much better. In case this is not the intended behaviour, we can just revert the corresponding commit.

Was tested and works on OpenShift 4.11 cluster.

Addresses #302

sthaha commented 6 months ago

@BGrasnick I am going to close this due to the reason mentioned above. Please feel free to reopen if you have found a solution for this. Meanwhile we have added the dashboards to developer view as well. So any user with view role to the kepler deployment namespace should be able to see all metrics. See #369