POWERMON-235: Add support for Redfish

sustainable-computing-io / kepler-operator

Kepler Operator

Apache License 2.0

25 stars 26 forks source link

POWERMON-235: Add support for Redfish #364

Closed vimalk78 closed 6 months ago

vimalk78 commented 7 months ago

This PR

Extends Kepler and KeplerInternal API to add Exporter.Redfish
Redfish spec has fields for adding reference to a secret which should contain Redfish credentials.
The user supplied secret is mounted in the kepler container, and daemon set spec is changed which causes kepler containers to restart.
Added Unit tests and e2e test

sunya-ch commented 7 months ago

This PR made a change on Kepler resource. Shall we first limit this change to only KeplerInternal? Also, if redfish.secretRef is not set in the CR, it seems to make it not mounting since there is no default value for that.

vimalk78 commented 7 months ago

Also, if redfish.secretRef is not set in the CR, it seems to make it not mounting

thats by design. once secretRef is set, then only -redfish-cred-file-path is added to container

sthaha commented 7 months ago

@vimalk78 nice work overall. It worked pretty well in my test. But few comments to address. The main one being that secret must be present for kepler deployment to continue and the reason for failure to deploy must be reported back in Availability status.