sustainable-computing-io / kepler

Kepler (Kubernetes-based Efficient Power Level Exporter) uses eBPF to probe performance counters and other system stats, use ML models to estimate workload energy consumption based on these stats, and exports them as Prometheus metrics
https://sustainable-computing.io
Apache License 2.0
1.06k stars 170 forks source link

Document or Disable the Snyk Security/License Checks #1507

Open dave-tucker opened 1 month ago

dave-tucker commented 1 month ago

What happened?

1438 failed CI on the Snyk checks.

There is no information available for:

  1. What these checks do
  2. What a contributor can do to address the concerns

What did you expect to happen?

If CI is failing, I expect to get some signal as to what is wrong and how it can be fixed.

How can we reproduce it (as minimally and precisely as possible)?

N/A

Anything else we need to know?

No response

Kepler image tag

N/A

Kubernetes version

N/A ```console $ kubectl version # paste output here ```

Cloud provider or bare metal

N/A

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ```

Install tools

N/A

Kepler deployment config

For on kubernetes: ```console $ KEPLER_NAMESPACE=kepler # provide kepler configmap $ kubectl get configmap kepler-cfm -n ${KEPLER_NAMESPACE} # paste output here # provide kepler deployment description $ kubectl describe deployment kepler-exporter -n ${KEPLER_NAMESPACE} ``` For standalone: # put your Kepler command argument here

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

dave-tucker commented 1 month ago

@rootfs can you shed some light on what these are for?

They are showing up on PR as failing checks for $reasons. After I got access to see what is going on some of it was valid and some of it was utter nonsense. If they can't reliably pass/fail and give clear instructions on remediation they should be removed from the PR CI jobs. They could be run as part of a the scheduled build though.

dave-tucker commented 1 month ago

Noting that Snyk is hallucinating hard on #1538

I'm going to change the webhook to only run on main for now until we can figure out what is up