sustainable-processes / ORDerly

Chemical reaction data & benchmarks. Extraction and cleaning of data from Open Reaction Database (ORD)
MIT License
69 stars 8 forks source link

Only test remove_inconsistent_yields once #136

Open dswigh opened 1 year ago

dswigh commented 1 year ago

Tests take a long time, and one reason is that we've got remove_inconsistent_yields as a bool that we vary with two other bools a lot of times. This means we have (3x3=9) test cases in the cleaner instead of (2x2=4), and in the extractor we are also extracting all data multiple times with remove_inconsistent_yields=T/F. It's a relatively simple function, so we should just have a separate test for it.