search

sustainable-processes / summit

Optimising chemical reactions using machine learning
https://gosummit.readthedocs.io/en/latest/
MIT License
120 stars 25 forks source link

Bugs in SnAr benchmark function? #185

Closed Yujikaiya closed 2 years ago

Yujikaiya commented 2 years ago

I'm not so sure but, If my understanding is correct, the code below r[3] = k_a * C[0] * C[1] - k_d * C[1] * C[3] should be r[3] = k_b * C[0] * C[1] - k_d * C[1] * C[3]

It would be appreciated if you check this when you have time.

marcosfelt commented 2 years ago

Hi Yuji! I think you might be right about this. Let me check tomorrow. Thanks for bringing it up!