sustainable-processes / summit

Optimising chemical reactions using machine learning
https://gosummit.readthedocs.io/en/latest/
MIT License
118 stars 24 forks source link

Sweep: Transform should iterate over transform_domain #256

Closed marcosfelt closed 1 year ago

marcosfelt commented 1 year ago

This should be transform_domain: https://github.com/sustainable-processes/summit/blob/8b987dee789eeb6e7e87184e935425330e2501f5/summit/strategies/base.py#L99

sweep-ai[bot] commented 1 year ago

Hi @marcosfelt,

I've started working on this issue. The plan is to modify the transform_inputs_outputs method in the Transform class to iterate over self.transform_domain.input_variables instead of self.domain.input_variables. This change will ensure that the transformations are applied on the modified domain rather than the original domain.

Give me a minute!

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/sustainable-processes/summit/blob/8b987dee789eeb6e7e87184e935425330e2501f5/summit/benchmarks/MIT/MIT_kin_case1.py#L1-L8 https://github.com/sustainable-processes/summit/blob/8b987dee789eeb6e7e87184e935425330e2501f5/summit/strategies/deep_reaction_optimizer.py#L1-L19 https://github.com/sustainable-processes/summit/blob/8b987dee789eeb6e7e87184e935425330e2501f5/summit/strategies/factorial_doe.py#L1-L7 https://github.com/sustainable-processes/summit/blob/8b987dee789eeb6e7e87184e935425330e2501f5/summit/strategies/random.py#L1-L8 https://github.com/sustainable-processes/summit/blob/8b987dee789eeb6e7e87184e935425330e2501f5/summit/strategies/base.py#L1-L1203

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!