Internet Unavailable PopUp

sustcast / sustcast-android-app-v1

📻 Android Application for SUSTcast [Online Radio Station]

https://tinyurl.com/sustcast

14 stars 7 forks source link

Internet Unavailable PopUp #11

Closed shuhanmirza closed 4 years ago

istiakshihab commented 4 years ago

Added an internet checker to LandingActivity. Why LandingActivity only?

It only made sense because authChecking will be happening in SplashActivity anyway and on failure will be returned to LandingActivity. So in case of internet failure, it will go to that specific activity.

@shuhanmirza Please close the issue if you are satisfied with the approach.

shuhanmirza commented 4 years ago

I think we should have a helper function. So that we can check connectivity from any activity. And if connectivity is not present, a dialog popup will be shown or every activity will just be directed to the landing activity.

Sounds right?

istiakshihab commented 4 years ago

Yes, I did that. But is it necessary to check this in every activity that gets redirected from LandingActivity as it's the parent layout anyway? by every activity, I meant LoginActivty SignUpActivity and others. Make an issue for @appledora if you want it to be used in her fragments too.

shuhanmirza commented 4 years ago

Let's discuss this on next meeting.

istiakshihab commented 4 years ago

Closing issue.