search

sustrik / dsock

An obsolete project
Other
82 stars 23 forks source link

Fix incorrect http header field-value processing #22

Closed pudelkoM closed 7 years ago

pudelkoM commented 7 years ago

field-values can contain whitespace, see: https://tools.ietf.org/html/rfc7231#section-7.1.1.2 for an example. Add test case to check this.

Without looking to deep into the other code, I'd estimate that there might be more subtle bugs in the http processing functions. That opens the question if such code should not be taken from other, already well tested libraries instead.

sustrik commented 7 years ago

Can you state that patch is submitted under MIT/X11 licence? I'll also need your name and email address to add to AUTHORS file.

As for using stock code, if you are aware of something with MIT license, I'll be happy to accept the patch.

pudelkoM commented 7 years ago

Sure thing: This patch is submitted under the MIT/X11 license. The name/email would be Maximilian Pudelko and maximilian.pudelko@gmail.com

sustrik commented 7 years ago

Merged. Thanks!