search

susy-bakaa / LCSoundTool

Simple Lethal Company sound tool and debugger.
MIT License
12 stars 5 forks source link

incompatibility issues with mods that add new sounds #9

Open HamedAlmanthari opened 9 months ago

HamedAlmanthari commented 9 months ago

hello, i noticed that sounds from some mods play randomly with this mod. for example, sounds of demogorgon spawning from StrangerThingsMod play when the ship lands with this mod, when it shouldn't obviously. and also sounds from FacilityMeltdown play randomly, whether in orbit or when i land. i have a video example here of StrangerThingsMod demogorgon spawn sound. https://github.com/no00ob/LCSoundTool/assets/133137232/7c0424cd-615d-4ef3-8d3c-1b9480c1e3f9

HamedAlmanthari commented 9 months ago

i confirmed the issue by downloading only lethalresonance, StrangerThingsMod, and their dependencies. i also tried with FacilityMeltdown.

susy-bakaa commented 9 months ago

Hey, thanks for reporting. I will take a look for the next update, but it sounds like these issues could be something on the other mods end that I can not fix and you would have to ask the other mod authors to make sure their custom audio is setup in a way which works well with my mod.

HamedAlmanthari commented 9 months ago

hi, np. alright i'll report this to them.

LoafOrc commented 9 months ago

hey creator of facility meltdown here! had this issue linked in my discord thread. i've created a custom api for moons to add custom music (look here for the implementation but i think for this use case you'll have to publicize the mods dll and override Assets.defaultMusic. assets.cs

edit: if there is some easy api i can hook into i'd be happy to provide support on my end

susy-bakaa commented 9 months ago

Hey, awesome to hear! My mod should in theory require no extra work, but it depends on how your or other mods setup their audio on the Unity side. How does your mod implement the audio when it comes to Unity audio sources? Do they get created and setup at runtime? About the only thing my mod might mess up is that it tries to add it's own custom component to audio sources with playOnAwake set to true, to take over their playback, but other than that it should work without any extra work. If you wanna further discuss compatibility you can contact me through discord @no00ob.