sutex / lcdmiscellany

Automatically exported from code.google.com/p/lcdmiscellany
0 stars 0 forks source link

Bug with ManualScrollingText #14

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Please describe the problem:

The logic for Bump() is reversed.

    function %Bump() {
        if (%width < %textWidth) {
            return 0;
        }
        %offset -= %shift;
        if (%offset+%overflow + %textWidth < %width) {
            %offset = %overflow;
        }
        return 1;
    }

should be

    function %Bump() {
        if (%width > %textWidth) {
            return 0;
        }
        %offset -= %shift;
        if (%offset+%overflow + %textWidth < %width) {
            %offset = %overflow;
        }
        return 1;
    }

Original issue reported on code.google.com by gene....@gmail.com on 5 Dec 2010 at 4:41

GoogleCodeExporter commented 9 years ago
You're right.  I don't use the media player much (Or at all, since my G19 
died)...  Still, really should test a bit more before "fixing" things.  Thanks.

Fix much more, and I'll have to give you SVN access.  Should update the 
official version, too, come to think of it.

Original comment by mattme...@gmail.com on 5 Dec 2010 at 5:00

GoogleCodeExporter commented 9 years ago
Glad to be of assistance, and I'm sorry to hear that your G19 died.
I'm using a G15 myself.  Still not using it to its full potential, there are 
many things I'd like to do with it (but was too lazy to code.)

LCDMisc is the only applet I use and I'd love to see it live on.
I'll contribute what I can. :)

Original comment by gene....@gmail.com on 5 Dec 2010 at 5:07