search

sutoiku / formula.js

JavaScript implementation of most Microsoft Excel formula functions
Other
2.14k stars 293 forks source link

refactor + more fixes + input type checking and parsing #28

Closed joaojeronimo closed 10 years ago

joaojeronimo commented 10 years ago

It's https://github.com/sutoiku/formula.js/pull/26 plus the proper type checking and parsing for all formulas and some more fixes.

hmalphettes commented 10 years ago

Thanks @joaojeronimo please bear with us while we disgest this and we are busy with our private development for the next couple of days. One thing for sure we will need is to put ACCRINT back... even if the implementation was not perfect it seems we are using it.

hmalphettes commented 10 years ago

wOOt! It is in!

jalateras commented 10 years ago

Gents, We really appreciate your massive contribution. The refactor has really enhanced the quality of the project. @joaojeronimo, how would you like to be recognized for this contribution - as a single entity, as a company contribution etc.

jalateras commented 10 years ago

I'll push to the public npm registry in the next couple of days.

joaojeronimo commented 10 years ago

Thank you for merging :) @jalateras as a company would be nice, we are CrowdProcess.