suttacentral / bilara

Our Computer Aided Translation software
10 stars 8 forks source link

ensure update is reliable and displays appropriate error messages #130

Open sujato opened 1 year ago

sujato commented 1 year ago

The process of updating texts (and probably publishing too, but I use that less often) is complex, and we are getting a range of often-misleading or useless error messages. These are all persistent problems, they have been around for months.

Github actions regularly show as incomplete

When an update is done we see GA messages like this:

Screenshot from 2022-11-13 09-35-24

But the action has in fact completed properly. It seems there are several actions on Github when a single process is initiated by the user. Surely there should only be one GA per user-initiated action.


updating large collections shows Bilara error

It is useful to update a the highest level that is reasonable. Typically if I update DN it is fine, but if it is AN it is not. But then the PR shows up a minute later on Github anyway. So it seems to work, but the error message has a time limit? Or something like that!

Screenshot from 2022-11-13 09-50-03

And here is that same update, which a minute later appears on Github as a PR:

Screenshot from 2022-11-13 09-51-24

It's a mystical process of discovery and adventure!

Updated texts do not show as updated

After hitting update and completing the process, the UPDATE button on Bilara is still visible, even after a refresh. I suspect this has something to do with a difference between the source and nilakkahana transformed files, but that is just a guess.

Obviously this means you never know what actually needs to be updated!

Screenshot from 2022-11-13 09-47-48

Some of these collections have just been updated. Some have not. Which is which?

sabbamitta commented 1 year ago

On updating texts:

Screenshot from 2022-11-16 10-16-06

The first thing I translated yesterday was SN35.124, and it showed immediately the progress (green) and the "update" button (you have to guess, because it is in the text).

Later I translated up to SN35.129, but don't see the progress, despite page refresh.

This morning I translated SN35.130, and there is still no progress showing, despite reboot of my computer this morning. I see the "update" buttons however.

Lacking update of progress count is sometimes for weeks, and at some point then it is suddenly there.

(SN35.132 has been translated a longer while ago.)

sujato commented 1 year ago

the progress (green) and the "update" button

As for this error, the basic problem is that the CSS design is not really adequate. I'm wanting to address this in the current round of updates, but we should put any related issues on the existing proposal:

https://github.com/suttacentral/bilara/issues/63

We can develop this as we go..