search

suttacentral / bilara

Our Computer Aided Translation software
10 stars 8 forks source link

Clicking on TM prompt saves string #19

Closed sujato closed 5 years ago

sujato commented 5 years ago

When accepting a TM prompt the accepted string seems to be persistent. I am not sure if it is actually committed or not, but if you click away and then come back, the accepted string is still there.

This is an anti-pattern, as we should only commit strings by Enter. Failure to do so creates an ambiguous state. The string should be discraded when you navigate away.

Strings must only but committed by Enter. If a TM prompt is accepted, but not committed by Enter, when one navigates away the string is discarded.

blake-sc commented 5 years ago

State is now committed only by Enter. Furthermore there is an indicator next to an entry either warning that it has been modified but not committed, or acknowledging that it has been committed.