search

suttacentral / sc-data

Content for SuttaCentral, including texts both legacy and bilara, parallels, structure, and other metadata.
43 stars 39 forks source link

minor correction to parallels.json #272

Closed thesunshade closed 9 months ago

thesunshade commented 9 months ago

Sorry for such a small PR.

This completes https://github.com/suttacentral/suttacentral/issues/1471

ayya-vimala commented 9 months ago

Okay, I had a look and this is what I think is going on. First of all, please mind the instructions in the wiki: https://github.com/suttacentral/suttacentral/wiki/Parallels-information

Then I had a look at mkv66, mkv25 and dhp 1 and 2. It seems to me that indeed mkv66 is not a partial parallel. But mkv25#3 is a full parallel to dhp 1 and 2 together (and partial to each one separate).

So lets have a look here in detail and how to change that. There are 5 entries for parallels that are relevant here:

"parallels": ["dhp1","gdhp201","pdhp1","t210.9#vgns9.1","t212.32#vgns32.13","t213.31#vgns31.13","uv31#31.23","~mkv66","uv-kg31#793","uvs31#31.20"]

"parallels": ["dhp2","gdhp202","pdhp2","t210.9#vgns9.2","t212.32#vgns32.14","t213.31#vgns31.14","uv31#31.24","~mkv66","uv-kg31#794","uvs31#31.21"]

"parallels": ["mkv66","~dhp1-2","~gdhp201-202","~pdhp1-2","~t210.9#vgns9.1-#vgns9.2","~t212.32#vgns32.13-#vgns32.14","~t213.31#vgns31.13-#vgns31.14","~uv31#31.23-#31.24","~uv-kg31#793-#794","~uvs31#31.20-#31.21"]

"parallels": ["mkv25#3","~mkv32#14","uv31#31.23-#31.24"]

"parallels": ["~mkv25#3","mkv32#14","uv31#31.24"]

You are right to say that these are not entirely correct.

For indeed the first two, mkv66 has to be replaced with mkv25#3 (and partial, as it is part dhp 1 and part dhp 2). Because in the first two the full parallels are: ["dhp1","gdhp201","pdhp1","t210.9#vgns9.1","t212.32#vgns32.13","t213.31#vgns31.13","uv31#31.23","uv-kg31#793","uvs31#31.20"] (So basically everything else than the mkv entry) in the third entry mkv66 has to be replaced with mkv25#3 (making that one part parallel to everything else)

Then rests the last two and there is mkv32#14 in there. That is indeed a part parallel to mkv25#3 but a full parallel to DHP 2. So mkv32#14 has to be added as a full parallel to the second entry and as a partial parallel to the third. The fourth and fifth entries need to be deleted.

So these five then become:

"parallels": ["dhp1","gdhp201","pdhp1","t210.9#vgns9.1","t212.32#vgns32.13","t213.31#vgns31.13","uv31#31.23","~mkv25#3","uv-kg31#793","uvs31#31.20"]

"parallels": ["dhp2","gdhp202","pdhp2","t210.9#vgns9.2","t212.32#vgns32.14","t213.31#vgns31.14","uv31#31.24","~mkv25#3","uv-kg31#794","uvs31#31.21", "mkv32#14"]

"parallels": ["mkv25#3","~dhp1-2","~gdhp201-202","~pdhp1-2","~t210.9#vgns9.1-#vgns9.2","~t212.32#vgns32.13-#vgns32.14","~t213.31#vgns31.13-#vgns31.14","~uv31#31.23-#31.24","~uv-kg31#793-#794","~uvs31#31.20-#31.21", "~mkv32#14"]

I know this sounds complex but you get used to it! I submitted a proposal 5 years ago for making it easier but that was never taken up. If every you have questions about this, please feel free to contact me.

ayya-vimala commented 9 months ago

Changed to new PR #274