search

suusan2go / kotlin-fill-class

Intellij plugin that provides intention action for empty constructor
https://plugins.jetbrains.com/plugin/10942-kotlin-fill-class
MIT License
268 stars 31 forks source link

Add Value Generator #84

Closed theapache64 closed 1 year ago

theapache64 commented 1 year ago

Before

https://user-images.githubusercontent.com/9678279/207439479-b658c160-6962-4d6b-8e27-bb8911aab06a.mov

After

https://user-images.githubusercontent.com/9678279/207439506-bc721bd8-bcbb-41e4-aa46-e4dbcbca4e65.mov

theapache64 commented 1 year ago

@suusan2go Test cases are failing because of the output format change. Will fix that if the feature looks good to you :)

oboenikui commented 1 year ago

@theapache64 Thanks for the great feature PR!

However, based on our experience with this plugin, we feel that there are some use cases that should be filled with traditional default parameters, especially when used outside of test classes.

For example, if you could create a separate inpection menu, such as "Fill with dummy values", I would personally be happy to support any use case. Would you consider modifying that way?

theapache64 commented 1 year ago

Sure. I was thinking of the same. Will make the change and let you know :)

theapache64 commented 1 year ago

@oboenikui Done the changes 👍 What do you think ?

https://user-images.githubusercontent.com/9678279/207697567-fc098b13-3708-4a95-936d-ec9d5cf6db5c.mov

theapache64 commented 1 year ago

@oboenikui Can we merge this now?

oboenikui commented 1 year ago

I have added the test and resolved the conflicts and will merge it in. I had to add a commit to another branch, so it is not shown in the diff for this PR. The diff is as follows: https://github.com/suusan2go/kotlin-fill-class/commit/8b9dfdd8c352fd62591e8ae6a9a339552e60dfb0

Thanks for adding the feature!

ColtonIdle commented 1 year ago

WOOOO

theapache64 commented 1 year ago

Sorry all! Got busy with other stuffs. Let me know if you still need to make any refactor. Can raise another PR !! ✋

Thanks for merging it :)

oboenikui commented 1 year ago

This changes will be released as soon as it is reviewed by JetBrains. Thank you!

When I wrote the test, I changed some parts that were different from my expected behavior. But I apologize if this is not what you expect 🙏 In that case, please make a PR if necessary.

ColtonIdle commented 1 year ago

Got the updated plugin today. works like magic. thank you!