Open masonpam opened 6 years ago
Initial Style
I think your code is looking really great so far! I love that you have implemented a poem and an image to start getting the content and main portion of the website put together and adjusted.
Upon looking at a live view of the website, it seems the image overlaps into the other title cards on the main page. They would either need to move down to another area of the website underneath or above the poem and image combination, or removed completely for stylistic purposes.
Upon looking at your code, I see that you have a lot of page break
tags used to break apart the lines of the poem. While this is effective and gets the design display working properly, I think this is not the most efficient when adding a lot more poems and may end up reusing a lot of redundant code and endless copy+pasting.
A solution I think would be to make the container that the poem is in set to a specific height, then add a word-wrap CSS properly. That way, you can just add a class to each poem rather than a long string of line breaks. This is a great example provided by W3Schools
After adjusting the code to refactor the redundancy and adjusting the image overlap into a neighboring section, this code should be ready to merge and deploy.
Thanks Darya! I took away the extra card on the homepage and added the word-wrap property in the main CSS file.
I added one poem and one image to the homepage file. Added poem to lines 68-84 and image to 88-89, they will need to be checked for proper formatting and image added to any other image files.
Issue https://github.com/suwebdev/mingled-worlds/issues/5