search

suwebdev / spring-ghost

Spring Ghost repository for WATS 4020 18SQ
MIT License
1 stars 2 forks source link

nav-menu branch pull request #10

Open laura-reeve opened 6 years ago

laura-reeve commented 6 years ago

Issue: https://github.com/suwebdev/spring-ghost/issues/2

The navbar was already in place from initial master commit in index.html, so I only had to add some buttons and strip one style (kept the Bootstrap formatting and style already in place). I'm not sure what happened to make the entire page need to be re-written according to the diff comparison, but my work is solely focused on lines 46 - 55. I wrote lines 46 - 54 to add the buttons and then stripped the "navbar-right" class from the login form on line 55 (as this was making the buttons move in funky ways when resizing the screen).

I think that the buttons should be renamed once the actual pages are built (a button for poetry and a button for images instead of just one button for both, etc.). I would like for the menu buttons to eventually be shorter lengthwise so that the login form can remain where it is in alignment with the other elements in the navbar, especially when the screen is resized smaller.

Any help with re-naming buttons or adding new styles would be appreciated, especially concerning how the buttons and login form can fit onto the same line.

Closes #2

rosahughes commented 6 years ago

I suggest merging this now and renaming the buttons as we go.

ttully00 commented 6 years ago

I agree this is ready to merged with the master. Renaming can be done as we go. As far as the buttons go, if there was time, creating drop down menus could be an option. This way worrying about shortening and alignment with the log in form is not an issue.