search

suwebdev / spring-ghost

Spring Ghost repository for WATS 4020 18SQ
MIT License
1 stars 2 forks source link

Social sharing #11

Open ttully00 opened 6 years ago

ttully00 commented 6 years ago

Issue: #3

For social sharing I have added several icons for several social sharing websites. There maybe way to many icons. I was not sure which one to add. There probably only needs to be a select few. I have coded these to be at the top of the page. Also there are no links that will take you to the social sharing sites.

laura-reeve commented 6 years ago

Looks great, Tyrone, and I like the hover effect you created. I agree, there are a few too many icons. If we were continuing, we could bring this up at our next meeting and the whole team and/or the stakeholders could decide which social media icons are most important for this project. I think a max of 5 or 6 would be good?

rosahughes commented 6 years ago

After we get the sizing worked out and the number of buttons reduced appropriately, I recommend merging.

bbarrows89 commented 6 years ago

I'd agree, I've reduced the number of social sharing icons to 6 and cut back on links to services that don't make sense in the context of sharing poetry (youtube, spotify, etc). I also implemented some of the styling changes proposed by Laura.