search

suwebdev / spring-ghost

Spring Ghost repository for WATS 4020 18SQ
MIT License
1 stars 2 forks source link

sample-page branch pull request #9

Open laura-reeve opened 6 years ago

laura-reeve commented 6 years ago

Issue: https://github.com/suwebdev/spring-ghost/issues/1

Created "sample-page.html" at the root directory level (same level as index.html) and updated "css/main.css" with styles. Template comments are located within the sample-page.html code. I had created a copy of index.html to create sample-page.html, so the sample page code should be consistent with the home page, just with the new template content in the body.

It should be noted that this merge will also upload the sample image to a newly created "images" folder (which will also be created with the merge), so the sample image is located at "images/drops-needles-thaw-86074.jpg."

The styles are very basic, so if someone wants to add some ideas to main.css and jazz it up, please feel free! Look for the "Sample Page Styles" section.

Closes #1

rosahughes commented 6 years ago

Seeing this sample page in code makes me wonder whether we want to add comments on standard formatting here, or elsewhere in the project (for all new poems added).

ttully00 commented 6 years ago

After reviewing the code again I do see were there is comments almost before each line. I m not sure about what comments should be added or if any. I think maybe the comments that are there could be modified. But for the most part I don't see why this could not be merged into the master.