suyash-thakur / js-good-first-issues-finder

Javascript repositories with good first issues for newcomers to open source.
https://suyash-thakur.github.io/js-good-first-issues-finder/
MIT License
20 stars 15 forks source link

Create custom html template #2

Open suyash-thakur opened 1 year ago

suyash-thakur commented 1 year ago

Description: Currently, the script only supports HTML generated by markdown-to-html. We would like to add support for a HTML template, so that the website looks much better.

Proposed Solution: I propose to add a template.htmlfile which holds a better looking website template and the html generated by markdown-to-html get wrapped by the template file before written into index.html

Muhammad-Awab commented 1 year ago

I would like to work on this project. Please assign to me.

suyash-thakur commented 1 year ago

Hey @Muhammad-Awab. You can fork the repo and make a MR. Also reach me out if you need any help.

aparna03dubey commented 1 year ago

If this is still unresolved, please assign it to me.

suyash-thakur commented 1 year ago

@aparna03dubey I have assigned you the issue. Let me know if you need any help.

Parthiv31 commented 1 year ago

did you mean to enhance css of current index and put it in template.html for you to evaluate I mean Im starting out so kindly do assist me with your requirement so that I could help

suyash-thakur commented 1 year ago

@Parthiv31 Current index.html file is generated by using markdown-to-html package because of which there is not much room for styling the webpage. To fix this issue we can create a template.html file which will contain all the styling for the webpage and the html generated by markdown-to-html can be dynamically populated inside template.html.

suryanshgupta01 commented 1 year ago

@suyash-thakur I'm working on it, will fork it tonight only. Edit: DONE

geethdev commented 11 months ago

Hey! I would like to contribute!

simranroy01 commented 11 months ago

hey i would like to contribute, please assign it to me

Manideep-Maddileti commented 9 months ago

Hey..I want to work on this issue.Can you assign to me

saksham-jain177 commented 8 months ago

@suyash-thakur I would like to work on this, please assign it to me

Ishpreet01 commented 7 months ago

@suyash-thakur If this issue is still open, can I work on it?

suyash-thakur commented 7 months ago

@saksham-jain177 You have included node_modules in your PR 😬. Please exclude it and update your PR so that I can test it.

suyash-thakur commented 7 months ago

@Ishpreet01 You can pick up the other issue if you are are interested. I will wait for @saksham-jain177 to update his PR for now.

ROHIT-TECH-UNIVERSE commented 1 month ago

@suyash-thakur can i still work on it ?? you active??

suyash-thakur commented 1 month ago

Hey @ROHIT-TECH-UNIVERSE !! You can work on a PR for it. I am assigning the issue to you

ROHIT-TECH-UNIVERSE commented 1 month ago

thank you for assigning me @suyash-thakur can i connect to you with any other platform too so as to have a better understanding of what ur requirements are

ROHIT-TECH-UNIVERSE commented 1 month ago

@suyash-thakur i have done the changes just let me know when i can push the code

suyash-thakur commented 1 month ago

@ROHIT-TECH-UNIVERSE Can you create a PR ? I will review it once I get some time.

ROHIT-TECH-UNIVERSE commented 1 month ago

@suyash-thakur i have did it see and check it out i will post some images of new templete here Screenshot 2024-08-13 155431 image

mrinank1301 commented 5 days ago

if this is still active can u assign me this work??

suyash-thakur commented 5 days ago

Hey @mrinank1301 !! I have assigned it to you. Let me know if you need any help.

mrinank1301 commented 5 days ago

Ok I ll be submiting that tmwr is it ok?

suyash-thakur commented 5 days ago

It's fine. Take your time.

mrinank1301 commented 4 days ago

@suyash-thakur I had made the PR for the issue please review it and update me if there are any changes.