Fixes Write() Failure on SQ Element with SkipVRVerification() set

suyashkumar / dicom

⚡High Performance DICOM Medical Image Parser in Go.

MIT License

935 stars 136 forks source link

Closed bpeake-illuscio closed 3 years ago

bpeake-illuscio commented 3 years ago

Hello. This closes #191.

I've pushed the evaluation of SkipVRVerification() into verifyVROrDefault() so defaults will be returned even with SkipVRVerification() set.

I've also added a guard for VR checking in writeVRVL() for tag.ItemDelimitationItem like the one for tag.SequenceDelimitationItem.

Lastly, I've added two tests to guard against regressions. These tests failed before the changes were made.

suyashkumar commented 3 years ago

(Also, this is my first time reviewing a PR from the GitHub mobile app. It's pretty cool!)

bpeake-illuscio commented 3 years ago

No problem! Glad to be of service!