search

suyashkumar / dicom

⚡High Performance DICOM Medical Image Parser in Go.
MIT License
933 stars 136 forks source link

Handle unknowns completely #234

Closed jabillings closed 2 years ago

jabillings commented 2 years ago

This PR combines this existing branch with the updates made here.

Hopefully this comprehensively handles unknown DICOM elements.

(Note: this PR also contains the changes from my PR currently up)

suyashkumar commented 2 years ago

Suggestion: this PR may read cleaner if you branch off of the existing changes branch and add on top as needed. I'm not sure if this PR needs the changes from your other PR #233, but if not then that will probably be the cleanest way to setup and review the salient changes in this PR (and make it less likely to be stale as changes are made in the other PRs etc)! You can also probably rebase your new branch to incoporate the changes already merged into main (or if needed I can rebase s/read-un-as-sq).

jabillings commented 2 years ago

I'll close this PR now that #235 is up