Closed tcheever closed 1 year ago
Formal commit message aside, thank you for creating this library 😃. It has been very useful!
Hi @tcheever just wanted to check in and see if you had a chance to consider the review comments? Thanks for the contribution! There may be some interplay with #245 as well as a heads up based on how these PRs progress.
Hi @suyashkumar, thanks for the bump and the review. I did not see your comments and suggestions. I will get back to you as soon as possible.
Hi @tcheever thanks for the responses, added a couple more comments for your consideration!
@suyashkumar, if I'm understanding correctly, you do not want the option in the reader at all and you do not want the arg added to NewReader
?
Having an option like this would also be useful for us.
We are also interested in that option, I'd be happy to help if needed.
Thanks folks for the interest! I've circled back to this in #255, including making structural changes I wanted in #254 to support better option availability to read* methods in read.go (which was the subject of my comments in the review discussion here above).
Thanks @tcheever and others for the discussion and interest in this useful feature!
Going to close this for now, since this feature was introduced in #255 with the new options availability (merged to main)! @NMerzVerily @rronan @b3n3d17 @tcheever please feel free to kick the tires on it and let us know how it goes.
Testing