search

suyashkumar / dicom

⚡High Performance DICOM Medical Image Parser in Go.
MIT License
933 stars 136 forks source link

Update GitHub Actions #248

Open DimitriPapadopoulos opened 1 year ago

DimitriPapadopoulos commented 1 year ago

Not sure where the "bench_pr / Benchmark (PR)" CI failure comes from. This line: https://github.com/suyashkumar/dicom/blob/b667091a74dc7bbf92c2c061867ab5fdd4cab2b0/.github/workflows/bench_pr.yml#L29 yields:

HEAD is now at 12298c9 Merge d20b5f92ac52215c1e368f03cab86d1d5ec15e59 into b667091a74dc7bbf92c2c061867ab5fdd4cab2b0

Where does 12298c9 come from? A cached erased commit?

DimitriPapadopoulos commented 11 months ago

Updating actions/checkout@v1 to actions/checkout@v3 or even actions/checkout@v2 breaks "Benchmark (PR) " CI job. Let's leave it at @v1 for now.

suyashkumar commented 1 week ago

Hi there thanks for the contribution! Feel free to rebase this and we can get it in, or we can send a separate PR.