search

suyashkumar / dicom

⚡High Performance DICOM Medical Image Parser in Go.
MIT License
945 stars 138 forks source link

allow for reading until EOF with the function ParseUntilEOF #273

Closed amitbet closed 1 year ago

amitbet commented 1 year ago

The -new- PR for this from another branch.

This fix allows reading until EOF, without providing "bytesToRead", it keeps the previous Parse signature for backwards compatibility and creates a new ParseUntilEOF function which doesn't require the extra param.

amitbet commented 1 year ago

can you check out the changes I made and pull this PR into the code?

amitbet commented 1 year ago

ok, I added your changes and removed the additional const in parse.go

suyashkumar commented 1 year ago

Thank you! Can you take a look at this comment when you get a chance? https://github.com/suyashkumar/dicom/pull/273/files#r1183167194 I can also send a PR to your branch to do it if easier!

EDIT: I did a quick pass at this and opened https://github.com/amitbet/dicom/pull/1/files. If you merge that into your contrib branch, I think the commit should automatically show up on this PR as well.

amitbet commented 1 year ago

ok, i approved & merged it.

amitbet commented 1 year ago

can you approve this PR?

amitbet commented 1 year ago

Thanks :)

bench commented 1 year ago

great work @amitbet ! I was just searching for this change :heart: