search

suyashkumar / dicom

⚡High Performance DICOM Medical Image Parser in Go.
MIT License
933 stars 136 forks source link

fatal exit without defer #277

Closed maddin200 closed 1 year ago

maddin200 commented 1 year ago

/cmd\dicomutil\main.go line 67 Code: if err != nil { log.Fatalf("error parsing data: %v", err) // <-- will not use defer }

suyashkumar commented 1 year ago

I think you are pointing out that log.Fatalf exits the example dicomutil program without running the defered functions? Thanks for pointing it out, I'll make some updates in #278 (probably dicomutil in general could use a refactor to be honest).

suyashkumar commented 1 year ago

Addressed in dicomutil in #278