search

suyashmathema / mongoose-os-modbus

Other
6 stars 3 forks source link

Include in mongoose-os-libs #1

Open pimvanpelt opened 4 years ago

pimvanpelt commented 4 years ago

Hoi,

I stumbled across your library here as I was starting a project with Modbus/RS485 transceiver. I was wondering if you'd like to host this library in the Mongoose OS github on github.com/mongoose-os-libs/modbus/ ?

If yes, I can help you import it, as maintainer of the -libs and -apps org. If no, no worries, then feel free to close this issue so I'm aware. There'd be a little bit of work to import it (some of the copyrights point to Cesanta at the moment, and I think that should be you, assuming you're the original author of the code here), some .c / .h files are not tagged with an owner or might be third party (like the CRC16 code), etc. Nothing major, a few PRs would be sufficient to get this tidied up and published. Just let me know if you'd like to move it over.

Do you have a demonstration application as well (could go alongside github.com/mongoose-os-apps/modbus-demo/ for example). Let me know and I'd be happy to help you out here.

suyashmathema commented 4 years ago

Hey,

I would be happy to import it as mongoose lib. Can you let me know the copyright points that needs to be added? Let me know what else needs to be done. I can get a demo app ready as well.

Thanks, Suyash Mathema

On Thu, Apr 30, 2020 at 5:35 PM Pim van Pelt notifications@github.com wrote:

Hoi,

I stumbled across your library here as I was starting a project with Modbus/RS485 transceiver. I was wondering if you'd like to host this library in the Mongoose OS github on github.com/mongoose-os-libs/modbus/ ?

If yes, I can help you import it, as maintainer of the -libs and -apps org. If no, no worries, then feel free to close this issue so I'm aware. There'd be a little bit of work to import it (some of the copyrights point to Cesanta at the moment, and I think that should be you, assuming you're the original author of the code here), some .c / .h files are not tagged with an owner or might be third party (like the CRC16 code), etc. Nothing major, a few PRs would be sufficient to get this tidied up and published. Just let me know if you'd like to move it over.

Do you have a demonstration application as well (could go alongside github.com/mongoose-os-apps/modbus-demo/ for example). Let me know and I'd be happy to help you out here.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/suyashmathema/mongoose-os-modbus/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVOA33JWJQGNQP2AKMNAT3RPFQYHANCNFSM4MVOMQIQ .

pimvanpelt commented 3 years ago

Hi Suyash - I was working on my modbus project and was reminded of this offer here. I have created https://github.com/mongoose-os-libs/modbus for your and invited you as maintainer of the repo. You're more than welcome to upload your current repo into that central spot, and it'll be tagged and published alongside all the other mongoose libraries.

Due to the rename (just modbus rather than mongoose-os-modbus, the tweak to mos.yml that renames it will no longer be necessary.

pimvanpelt commented 3 years ago

By the way, the copyright points: I see you've added an APACHE 2.0 license, great! When tagging the files you wrote, you copied over the license blurbs from Cesanta, but I'm pretty sure they are not the copyright holders or authors :)

You could consider replacing * Copyright (c) 2014-2018 Cesanta Software Limited with your own name, or that of the people who inspired your project (like the Arduino project you linked in README.md)

suyashmathema commented 3 years ago

Hey I will make the necessary changes and upload the code to the repository you mentioned.

suyashmathema commented 3 years ago

I updated the copyright names and updated the central mongoose os repository. Do we need to add tags or does it auto tag from the new version?

pimvanpelt commented 3 years ago

it automatically tags upon new releases. Thanks! Issue here can be closed :) and welcome to the community. We're on gitter.im in case you're interested to stop by.

On Sat, Jan 23, 2021 at 5:11 PM suyashmathema notifications@github.com wrote:

I updated the copyright names and updated the central mongoose os repository. Do we need to add tags or does it auto tag from the new version?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/suyashmathema/mongoose-os-modbus/issues/1#issuecomment-766111263, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDRSPLXCNRIB3IIQAMFZDTS3LYKXANCNFSM4MVOMQIQ .

-- Pim van Pelt pim@ipng.nl PBVP1-RIPE - http://www.ipng.nl/