search

suzaku-network / suzaku-contracts-library

An open-source smart contracts library curated by the Suzaku team
Other
4 stars 0 forks source link

ICM: Use a different naming than `Home` and `Remote` for the source and destination bridge #2

Closed Nuttymoon closed 1 month ago

Nuttymoon commented 4 months ago

As noticed by Martin from Ava Labs, the current naming is confusing:

Just one question: I believe you assume the home and the router are always deployed on the same chain, right? The home does not necessarily have to be the C-Chain, but may also be a Subnet: ... Not sure if it actually matters in your implementation if the bridge is a home or remote bridge or if you actually just mean bridge contract on the chain of the router or on another chain. From a first look it looks to me like that's the case, so I think renaming this may do the job already:

I think that Source and Destination (welcome back hehe) might make sense in the context of the router as we are only bridging between 2 chains.

Nuttymoon commented 3 months ago

Also rename bridge to transferrer?