search

suzaku-network / suzaku-contracts-library

An open-source smart contracts library curated by the Suzaku team
Other
4 stars 0 forks source link

ICTT: `registerDestinationTokenBridge` does not allow destination chain to be the current chain #20

Closed Nuttymoon closed 7 hours ago

Nuttymoon commented 1 week ago

See issue #02 of the audit report.

Nuttymoon commented 1 week ago

I see two options here:

  1. We remove the destinationChainID == routerChainID if-statement in registerDestinationTokenBridge as recommended.
    @Al3xGROS do we agree that the multi-hop logic happens at the bridgeSource level? Meaning that it knows whether to do a multi-hop or not?
  2. We acknowledge the issue, saying that the Router is intended to bridge to other chains only because it only relies on canonical bridges and one token can only have one canonical bridge per chain.
Al3xGROS commented 5 days ago

Let's acknowledge this issue.