search

suzuki-0000 / CountdownLabel

Simple countdown UILabel with morphing animation, and some useful function.
MIT License
1.01k stars 192 forks source link

Fix expression to remove type-check compiler error in Xcode 12 #53

Open mushthak opened 4 years ago

mushthak commented 4 years ago

Hi There,

Created this PR to fix the issue(#52 ) causing type-check compiler error in Xcode 12.

Thanks for considering it!

hho114 commented 4 years ago

You can assign the owner as a reviewer to take a look at your PR.

mushthak commented 4 years ago

You can assign the owner as a reviewer to take a look at your PR.

There is no edit option in the reviewers section. I will add a comment down here. Hi @suzuki-0000 , awaiting review for this PR.

magnett commented 3 years ago

@mushthak it still doesn't compile using Xcode 12.2 error in CountdownLabel.swift, line 36 : Using '!' is not allowed here; perhaps '?' was intended?

mushthak commented 3 years ago

@magnett, For me it is a warning and no issue with compilation or running.

Screen Shot 2020-12-11 at 3 19 06 PM
magnett commented 3 years ago

You probably have the,iOS Deployment Target < 13.0 , that's why you get a warning instead of an error

Isuru-Nanayakkara commented 3 years ago

@mushthak it still doesn't compile using Xcode 12.2 error in CountdownLabel.swift, line 36 : Using '!' is not allowed here; perhaps '?' was intended?

Yep, I'm getting this error too.