search

suzuki-shunsuke / tfcmt

tfcmt enhances mercari/tfnotify in many ways, including Terraform >= v0.15 support and advanced formatting options
https://suzuki-shunsuke.github.io/tfcmt/
Other
417 stars 45 forks source link

Question. Skip posting a comment #1184

Open JeHuiPark opened 7 months ago

JeHuiPark commented 7 months ago

Free Text

Looking at the code at https://github.com/suzuki-shunsuke/tfcmt/blob/b9988d3e491412f58bf4280fdc2b1f3253137d35/pkg/config/config.go#L103-L106 it seems that the apply command does not support the when_no_changes.disable_comment option. Depending on the CI/CD operation style, there might be cases where we would want to use the when_no_changes.disable_comment option for the apply command. Is there a reason why tfcmt does not support this?

suzuki-shunsuke commented 7 months ago

Hi, thank you for your feedback. The reason why tfcmt didn't support this feature for terraform apply is just we didn't have any needs about this feature. I have no strong motivation for this at the moment, but maybe I'll take a look at this when I have time.

suzuki-shunsuke commented 7 months ago

📝 How to check if there is no change

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

https://github.com/suzuki-shunsuke/tfcmt/blob/b9988d3e491412f58bf4280fdc2b1f3253137d35/pkg/terraform/parser.go#L307