search

sv / kdbgo

kdb+ client driver for Go
MIT License
44 stars 29 forks source link

Testing With Q Installed #12

Closed yznima closed 5 years ago

yznima commented 5 years ago

I am thinking of addressing the installing q is in your future to install Q on Travis CI since I believe some of the tests are failing when run with Q installed on my machine

I was thinking we could check in the 32 bit binary of Q into the repository and run that. Do you have any approach in mind?

yznima commented 5 years ago

@sv What do you think about this?

sv commented 5 years ago

Terms and conditions of 32bit don't allow checking in binary into public repo. Maybe same approach that is used in https://github.com/KxSystems/pyq/blob/master/.travis/getkdb.sh can be used in other repos. go test would start q if it is in your path locally to test.

yznima commented 5 years ago

Sounds great. I will try to see If I can get it working

yznima commented 5 years ago

@sv Looks like in the line curl -O https://kx.com/$X/3.5/linuxx86.zip X is set outside the repository. Is this something that can be set by you?

sv commented 5 years ago

@yznima added X for curl -O https://kx.com/$X/3.6/linuxx86.zip

yznima commented 5 years ago

@sv It doesn't seem like the value of $X is present. See the logs in https://travis-ci.org/sv/kdbgo/jobs/513282026 for the curl command. The value is empty

sv commented 5 years ago

It would work only when built from sv/kdbgo repo. You would need to setup the same if you want to test your branches. To get value of X you need to register and agree to terms of service for 32bit and extract X from link you get for Linux. Then in your travis setup, add it to environment variables and tick 'hide from console' box.