search

sv / kdbgo

kdb+ client driver for Go
MIT License
44 stars 29 forks source link

Move Compress and Uncompress to compression.go #13

Closed yznima closed 5 years ago

yznima commented 5 years ago

Simple copying of compression code to a new file to allow further refactoring of encode.go and decode.go

yznima commented 5 years ago

@sv Ready for review

sv commented 5 years ago

What is your plan on further refactoring that needs separating compression to separate file? More idiomatic name would be compress.go

yznima commented 5 years ago

@sv

What is your plan on further refactoring that needs separating compression to separate file?

See #15. I thought it might be good to collocate this logic separate from encoding and decode. Thoughts?

yznima commented 5 years ago

@sv Addressed all comments

yznima commented 5 years ago

@sv ready for review