search

sv / kdbgo

kdb+ client driver for Go
MIT License
44 stars 29 forks source link

wrong cast to string in DialKDBTimeout #18

Closed ktye closed 5 years ago

ktye commented 5 years ago

In https://github.com/sv/kdbgo/blob/master/kdb.go#L208 the port, which is an int value is casted to a string by string(port). This is not correct. Consider using strconv.Itoa(port) or fmt.Sprintf.

sv commented 5 years ago

This is non-issue in https://github.com/sv/kdbgo/blob/v1beta/kdb.go branch. Will fix in current

sv commented 5 years ago

fixed in https://github.com/sv/kdbgo/commit/588f574a29a2f1456de0505b063ccdcc535e3208