lldb-vscode is now called lldb-dap

[skittishdev]

Since October 2019 https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075 https://lldb.llvm.org/resources/lldbdap.html

Also adds support for rustic-mode

[svaante]

This is great, thanks!

I do prefer that we still keep the lldb-vscode entry and make a new entry for lldb-dap I know there people are using the older version versions of lldb-vscode and I don't want to force them to update.

I propose that we use construct these two configurations in the same way that the codelldb entries are created

    ,@(let ((lldb-common
             `(modes (c-mode c-ts-mode c++-mode c++-ts-mode rust-mode rust-ts-mode rustic-mode)
               ensure dape-ensure-command
               command-cwd dape-command-cwd
               :cwd "."
               :program "a.out")))
        `((codelldb
           command "lldb-vscode"
           :type "lldb-vscode"
           ,@lldb-common)
          (lldb-dap
           command "lldb-dap"
           :type "lldb-dap"
           ,@lldb-common)))

Also have you checked out the Contribute section in the readme?

dape is subject to the same copyright assignment policy as GNU Emacs. Any legally significant contributions can only be merged after the author has completed their paperwork. See Contributor's Frequently Asked Questions for more information.

I don't think this + your readme changes counts as legally significant, but it would be an good idea to start the process if you are interested to continue to contribute to dape, other elpa packages or emacs itself.

[skittishdev]

I do prefer that we still keep the lldb-vscode entry and make a new entry for lldb-dap.. I propose that we use construct these two configurations in the same way that the codelldb entries are created

Makes sense. Added back lldb-vscode and used the pattern you recommended.

Also have you checked out the Contribute section in the readme?

Thank you for the reminder. I have initiated that process after making this change.