svaante / dape

Debug Adapter Protocol for Emacs
GNU General Public License v3.0
477 stars 31 forks source link

Add dape-on-terminated-hooks #48

Closed akurth closed 9 months ago

akurth commented 9 months ago

This is a naive attempt to fix #46. Hook is called within dape--kill-processes and thus allows to run code upon debug session termination.

svaante commented 9 months ago

Hi this seams like a fine change but dape--kill-process has been removed in the last change so the disable hook needs to be placed somewhere else.

svaante commented 9 months ago

After some further thought maybe it's a good idea to add an global mode like suggested in #27

akurth commented 9 months ago

Of course! A minor mode is in any case the better option; my proposal was just a workaround for the missing mode.

akurth commented 9 months ago

Now that dape-active-mode-hook exists, this is obsolete. Thanks!