search

svaante / dape

Debug Adapter Protocol for Emacs
GNU General Public License v3.0
455 stars 25 forks source link

Fix for default-directory not set to project root in ensure function #50

Closed MagielBruntink closed 8 months ago

svaante commented 8 months ago

Hey i have done some thinking and have redone some parts of read-config in #52 which should have this fix included. It would be beneficial with some feedback as well. Have done some changes to jdtls config.

I know it can be seen as an regression with the removal of `completing-read' "vscode.java.resolveMainClass" but I belive that it's preferable to have good defaults and then overwrite those values in the mini buffer.

MagielBruntink commented 8 months ago

Looks good to me! In light of my previous remarks on the use of attach rather than launch for Java, your proposal doesn't look like a regression to me.