search

svaante / dape

Debug Adapter Protocol for Emacs
GNU General Public License v3.0
455 stars 25 forks source link

Fix invalid-face-reference #65

Closed timcharper closed 7 months ago

timcharper commented 7 months ago

Partially revert 0d6b9631to fix https://github.com/svaante/dape/issues/64

timcharper commented 7 months ago

Personally, I believe we should revert all of https://github.com/svaante/dape/commit/0d6b96318a157294ee53c06ce505ce8fb013e13c . It's pretty standard in Emacs for faces to end with -face.

Also, I'm not exactly sure why this caused the issue I am seeing, but it seems like something is changing the value of dape-breakpoint to a number.

timcharper commented 7 months ago

@svaante I converted this to a draft; I just wanted to have a reference point for you to easily see that this addresses the issue I found. Feel free to revert or resolve in a way you wish.

A partial revert is a terrible, but great to illustrate a fix by changing as few lines as possible.

timcharper commented 7 months ago

resolved with 37eb1c00156b2932e3387b712cb68436ee8962eb