Added isomorphic command handlers

svalaskevicius / eventflow

cqrs+es in scala

45 stars 4 forks source link

Added isomorphic command handlers #9

Closed Fristi closed 8 years ago

Fristi commented 8 years ago

Since a lot of commands are isomorphic to their event (only the name of the type differs). I introduced isomorphic command handlers.

TODO's:

[x] Restore wartremover (got this error: https://github.com/puffnfresh/wartremover/issues/188)
[x] safeCast and proofE seems a bit meh, any smarter tricks for that matter?

svalaskevicius commented 8 years ago

is it worth to just use @SuppressWarnings for the misreported wart? if not, then ignoring ExplicitImplicitTypes globally would be better than disabling everything until the update :)

I'm keen to merge this PR, thanks for this change! :)

Fristi commented 8 years ago

Done, fixed the issues

Added exclusion of wartremover isInstanceOf as it contains false positives as I encountered (see code)
Removed safeCast and proofE
Renamed handler to promote for now

svalaskevicius commented 8 years ago

awesome! :)