svalenti / pessto

pessto pipeline
MIT License
9 stars 6 forks source link

PESSTOEFOSC2dSPEC -f option #31

Closed cinserra closed 9 years ago

cinserra commented 9 years ago

According to the help

Options: --version show program's version number and exit -h, --help show this help message and exit -i, --interactive
-C, --cosmic
-v, --verbose
-f, --flat
-F LISTFLAT, --listflat=LISTFLAT name flat list [] -b, --bias
-B LISTBIAS, --listbias=LISTBIAS name bias list [] -a LISTARC, --listarc=LISTARC name arc list []

What does the -f options? I guessed it was needed if the user wanted to reduce the spectrum without flats (at least in PESSTOEFOSCPHOT it means so) since if he/she wants to use a particular list of flat there is the -F option. I tried to do a reduction without flats for testing the S/N with and without flats but the pipeline does not like the lacking of flats (it allows you only to skip or exit)

screen shot 2014-11-25 at 14 32 37

Furthermore, also the -B option could appear misleading since it asks for a list of bias but the usage points to a single fits (likely the masterbias)

screen shot 2014-11-25 at 14 34 28

svalenti commented 9 years ago

I don't understand why you want to reduce a single file with no flat field and no standard using PESSTO2DSPEC. you should use PESTOFAST for fast reducton. Anyhow if you want that I take a look you need to provide the files used

cinserra commented 9 years ago

As I wrote, it was a test to check the S/N with and without flat (I meant to use the standard). It is OK if the pipeline doesn't handle that since we need this option only for tests. However what does the -f option? Is the -B option requiring a list or a single bias (masterbias)?

svalenti commented 9 years ago

-f is the option to don't perform flat correction, -B to don't perform bias correction. -B take as input pre reduced bias (in the same format of the bias that are in the archive directory. It can take a single frame of a list of bias

cinserra commented 9 years ago

OK, so -f doesn't seem working properly as you can see from screenshot#1. It doesn't allow the user to proceed without flat or I am missing something?

svalenti commented 9 years ago

the option -f and -b were not working if the input was a single frame