svalenti / pessto

pessto pipeline
MIT License
9 stars 6 forks source link

Spectroscopic flats and arcs in the pipeline archive (EFOSC and SOFI) #35

Closed ekankare closed 9 years ago

ekankare commented 9 years ago

When running PESSTOEFOSC2dSPEC -i or PESSTOSOFI2dSPEC -i the pipeline is not using spectroscopic flats or arcs from the pipeline archive if there are no correct calibration files in the reduction folder. (Furthermore, I cannot even find spectroscopic flats for EFOSC and SOFI from the pipeline library.) Instead, this will essentially lead to pipeline exit/crash, see below. Is this intentional that by default the spectroscopic archive calibrations are not used? This is not very relevant for the DR2 reductions, but it could be useful for some users if the pipeline would make use of such files if necessary.

No flat example with EFOSC:

 ###Warning: flat with setup ('Gr13', 'Free', 'slit1.0') are missing

 ### skip this setup from reduction [s] or exit [e] ? [s] 

No flat for SOFI:

### making the list with raw data in the current directory ...... please wait

### error: spectroscopic flat noa available, add flats in the directory and try again

No arc example for EFOSC:

###Warning: arc with setup ('Gr13', 'Free', 'slit1.0') are missing

### skip this setup from reduction [s] or exit [e] ?  [s]

No arc for SOFI:

File "/Users/eskank/tools/nttpipeline/lib/python2.7/site-packages/ntt/sofispec2Ddef.py", line 513, in sofispecreduction
    if arcfile:
UnboundLocalError: local variable 'arcfile' referenced before assignment
svalenti commented 9 years ago

erkki I fixed PESSTOEFOSC2dSPEC in the bug branch

ekankare commented 9 years ago

Thanks for pointing this out. I tried the bug branch version. So it skips flat fielding and is making use of an archive arc if calibrations are missing with EFOSC.

svalenti commented 9 years ago

Erkki: Furthermore, I cannot even find spectroscopic flats for EFOSC and SOFI from the pipeline library. there are no spectroscopic flat field in the archive. the option at the moment are:

ekankare commented 9 years ago

I tested also the SOFI reductions without spectroscopic flats and arcs with version 2.2.6 and this works now, see Stefano's comment on issue #36. I think that this issue (#35) can be closed.