search

svalinn / ALARA

Simulation of transmutation and decay in nuclear systems
Other
27 stars 20 forks source link

Modernization of ALARA build #41

Open gonuke opened 5 months ago

gonuke commented 5 months ago

ALARA needs to have its build system and some language features udpated.

  1. Newer CMake version
  2. c++-17 standards don't allow dynamic exceptions - maybe other things?
MicahGale commented 5 months ago

Is there a specific version of CMake and c++ that this should be targeting?

ahnaf-tahmid-chowdhury commented 5 months ago

CMake 3.18 is recommended as it enables setting the minimum version of different packages. I'm not sure why we need to upgrade to C++17, but in such a case, we can replace dynamic exceptions (throw without an explicit exception specification) with appropriate error handling mechanisms such as std::exception and try-catch blocks.