search

svalinn / Cubit-plugin

Plugins and command extensions for Coreform Cubit
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

enabling 21.04 #113

Closed bam241 closed 3 years ago

bam241 commented 3 years ago

testing 21.04

bam241 commented 3 years ago

This was a test :)

B. Mouginot

On Aug 5, 2021, at 15:20, Paul Wilson @.***> wrote:

 @gonuke requested changes on this pull request.

Make sure we name the job correctly

In .github/workflows/21.04.yml:

  • branches:
    • develop
    • master
  • release:
  • types: # This configuration does not affect the page_build event above
    • created +env:
  • GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

  • +jobs:

  • main:
  • runs-on: ${{ matrix.os }}
  • strategy:
  • matrix:
  • cubit: [2021.5]
  • os: [ubuntu-20.04] ⬇️ Suggested change
  • os: [ubuntu-20.04]
  • os: [ubuntu-21.04] — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.
shimwell commented 3 years ago

Just for anyone reading this. This PR is just building the plugin using docker images instead of the base github action unix. The reson we are testing this is to produce the cubit plugin with different glibc versions. It appears that the version of glibc used when using the base github action unix to build is a bit older than versions available on Ubuntu 20.04, Ubuntu 21.04 and Debian. Glbc is tricky to upgrade so it is nice to have the plugin built with a range of versions

shimwell commented 3 years ago

Ah sorry I have broken it again, I think the updating git trick that works for ubuntu doesn't quite work for debian

shimwell commented 3 years ago

Looks like my attempt to add debian was a bit ambitious, the unix_share_build.sh script contains commands that install lsb-core and ubuntu_version that are not valid in debian 10.10

shimwell commented 3 years ago

I've started working on the debian build over here https://github.com/Shimwell/Cubit-plugin/pull/2 sorry for all the mess

shimwell commented 3 years ago

I think we can close this test PR now. Feel free to reopen if still needed